HDDS-7781. Change Get Key Info to return HSync info#4460
Merged
Conversation
smengcl
reviewed
Mar 23, 2023
jojochuang
commented
Mar 23, 2023
| public Builder addAllMetadata(Map<String, String> newMetadata) { | ||
| metadata.putAll(newMetadata); | ||
|
|
||
| setHSync(metadata.containsKey(OzoneConsts.HSYNC_CLIENT_ID)); |
Contributor
Author
There was a problem hiding this comment.
@smengcl this is what I was referring to.
Contributor
There was a problem hiding this comment.
Got it. Thanks!
The final goal is to prevent other clients from opening the file while the first client hasn't closed the hsync'ed file yet correct?
Contributor
Author
There was a problem hiding this comment.
Actually we want to enable this behavior such that any client can forcefully close open files (HBase expects this)
Change-Id: Ic92b5a2430222f368307b837f3bfe22bef24fb5e
szetszwo
approved these changes
Mar 27, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a isHsync field in OmKeyInfo. This field is not persisted in RocksDB but rather is inferred from the metadata if it has HSYNC_CLIENT_ID field.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7781
How was this patch tested?
Unit tests